Compare commits

..

11 Commits

Author SHA1 Message Date
Claude
717845015e Add feedback prompt back to code review comments
Restore the 👍/👎 feedback CTA to help gather signal on
code review usefulness.
2025-12-18 15:32:11 +00:00
Franklin Volcic
b31e2fd182 Merge pull request #14385 from anthropics/fvolcic/inline-comments
Add inline comments with suggestions to code-review plugin
2025-12-17 15:55:23 -08:00
Franklin Volcic
d2cb503247 Remove header, add Claude Code prompt for larger fixes 2025-12-17 15:32:23 -08:00
Franklin Volcic
5fe61207ff Allow committable suggestions up to 5 lines 2025-12-17 15:28:50 -08:00
Franklin Volcic
1ed82e6af0 Refine inline comment formatting: no Bug prefix, summary first, limit suggestion size 2025-12-17 15:27:37 -08:00
Franklin Volcic
2a61cb364c Add inline comments with suggestions to code-review plugin 2025-12-17 15:20:12 -08:00
GitHub Actions
6880bcbace chore: Update CHANGELOG.md 2025-12-17 21:55:53 +00:00
GitHub Actions
4392352687 chore: Update CHANGELOG.md 2025-12-16 22:06:07 +00:00
kashyap murali
c27c6f4e4a Merge pull request #14071 from anthropics/claude/slack-make-no-comment-default-Qqha8
Make no-comment the default for /code-review
2025-12-16 12:22:18 -08:00
GitHub Actions
0dde1fef97 chore: Update CHANGELOG.md 2025-12-15 23:49:39 +00:00
Claude
e4f682030b Make no-comment the default for /code-review
Change the default behavior of /code-review to output to the terminal
instead of posting a PR comment. Users can use the --comment flag to
explicitly post the review as a PR comment when desired.

This is more suitable for local development workflows where posting
comments to the PR is not always needed.
2025-12-15 17:50:32 +00:00
7 changed files with 85 additions and 279 deletions

View File

@@ -1,5 +1,44 @@
# Changelog
## 2.0.72
- Added Claude in Chrome (Beta) feature that works with the Chrome extension (https://claude.ai/chrome) to let you control your browser directly from Claude Code
- Reduced terminal flickering
- Added scannable QR code to mobile app tip for quick app downloads
- Added loading indicator when resuming conversations for better feedback
- Fixed `/context` command not respecting custom system prompts in non-interactive mode
- Fixed order of consecutive Ctrl+K lines when pasting with Ctrl+Y
- Improved @ mention file suggestion speed (~3x faster in git repositories)
- Improved file suggestion performance in repos with `.ignore` or `.rgignore` files
- Improved settings validation errors to be more prominent
- Changed thinking toggle from Tab to Alt+T to avoid accidental triggers
## 2.0.71
- Added /config toggle to enable/disable prompt suggestions
- Added `/settings` as an alias for the `/config` command
- Fixed @ file reference suggestions incorrectly triggering when cursor is in the middle of a path
- Fixed MCP servers from `.mcp.json` not loading when using `--dangerously-skip-permissions`
- Fixed permission rules incorrectly rejecting valid bash commands containing shell glob patterns (e.g., `ls *.txt`, `for f in *.png`)
- Bedrock: Environment variable `ANTHROPIC_BEDROCK_BASE_URL` is now respected for token counting and inference profile listing
- New syntax highlighting engine for native build
## 2.0.70
- Added Enter key to accept and submit prompt suggestions immediately (tab still accepts for editing)
- Added wildcard syntax `mcp__server__*` for MCP tool permissions to allow or deny all tools from a server
- Added auto-update toggle for plugin marketplaces, allowing per-marketplace control over automatic updates
- Added `plan_mode_required` spawn parameter for teammates to require plan approval before implementing changes
- Added `current_usage` field to status line input, enabling accurate context window percentage calculations
- Fixed input being cleared when processing queued commands while the user was typing
- Fixed prompt suggestions replacing typed input when pressing Tab
- Fixed diff view not updating when terminal is resized
- Improved memory usage by 3x for large conversations
- Improved resolution of stats screenshots copied to clipboard (Ctrl+S) for crisper images
- Removed # shortcut for quick memory entry (tell Claude to edit your CLAUDE.md instead)
- Fix thinking mode toggle in /config not persisting correctly
- Improve UI for file creation permission dialog
## 2.0.69
- Minor bugfixes

View File

@@ -22,23 +22,29 @@ Performs automated code review on a pull request using multiple specialized agen
- **Agent #4**: Analyze git blame/history for context-based issues
5. Scores each issue 0-100 for confidence level
6. Filters out issues below 80 confidence threshold
7. Posts review comment with high-confidence issues only
7. Outputs review (to terminal by default, or as PR comment with `--comment` flag)
**Usage:**
```bash
/code-review
/code-review [--comment]
```
**Options:**
- `--comment`: Post the review as a comment on the pull request (default: outputs to terminal only)
**Example workflow:**
```bash
# On a PR branch, run:
# On a PR branch, run locally (outputs to terminal):
/code-review
# Post review as PR comment:
/code-review --comment
# Claude will:
# - Launch 4 review agents in parallel
# - Score each issue for confidence
# - Post comment with issues ≥80 confidence
# - Skip posting if no high-confidence issues found
# - Output issues ≥80 confidence (to terminal or PR depending on flag)
# - Skip if no high-confidence issues found
```
**Features:**
@@ -114,17 +120,23 @@ This plugin is included in the Claude Code repository. The command is automatica
### Standard PR review workflow:
```bash
# Create PR with changes
# Run local review (outputs to terminal)
/code-review
# Review the automated feedback
# Make any necessary fixes
# Optionally post as PR comment
/code-review --comment
# Merge when ready
```
### As part of CI/CD:
```bash
# Trigger on PR creation or update
# Automatically posts review comments
# Use --comment flag to post review comments
/code-review --comment
# Skip if review already exists
```

View File

@@ -1,5 +1,5 @@
---
allowed-tools: Bash(gh issue view:*), Bash(gh search:*), Bash(gh issue list:*), Bash(gh pr comment:*), Bash(gh pr diff:*), Bash(gh pr view:*), Bash(gh pr list:*)
allowed-tools: Bash(gh issue view:*), Bash(gh search:*), Bash(gh issue list:*), Bash(gh pr comment:*), Bash(gh pr diff:*), Bash(gh pr view:*), Bash(gh pr list:*), mcp__github_inline_comment__create_inline_comment
description: Code review a pull request
---
@@ -11,7 +11,7 @@ To do this, follow these steps precisely:
- The pull request is closed
- The pull request is a draft
- The pull request does not need code review (e.g. automated PR, trivial change that is obviously correct)
- You have already submitted a code review on this pull request
- Claude has already commented on this PR (check `gh pr view <PR> --comments` for comments left by claude)
If any condition is true, stop and do not proceed.
@@ -52,13 +52,34 @@ Note: Still review Claude generated PR's.
6. Filter out any issues that were not validated in step 5. This step will give us our list of high signal issues for our review.
7. Finally, comment on the pull request.
7. Post summary comment FIRST using `gh pr comment` (if `--comment` argument is provided):
- Total number of issues found
- Brief one-line summary of each issue (no "Bug:" prefix)
- Or if no issues: "No issues found. Checked for bugs and CLAUDE.md compliance."
When writing your comment, follow these guidelines:
a. Keep your output brief
b. Avoid emojis
c. Link and cite relevant code, files, and URLs for each issue
d. When citing CLAUDE.md violations, you MUST quote the exact text from CLAUDE.md that is being violated (e.g., CLAUDE.md says: "Use snake_case for variable names")
8. THEN post inline comments for each issue using `mcp__github_inline_comment__create_inline_comment`:
- `path`: the file path
- `line` (and `startLine` for ranges): select the buggy lines so the user sees them
- `body`: Brief description of the issue (no "Bug:" prefix). For small fixes (up to 5 lines changed), include a committable suggestion:
```suggestion
corrected code here
```
For larger fixes (6+ lines or structural changes), do NOT use suggestion blocks. Instead:
1. Describe what the issue is
2. Explain the suggested fix at a high level
3. Include a copyable prompt for Claude Code that the user can use to fix the issue, formatted as:
```
Fix [file:line]: [brief description of issue and suggested fix]
```
**IMPORTANT: Only post ONE comment per unique issue. Do not post duplicate comments.**
Use this list when evaluating issues in Steps 4 and 5 (these are false positives, do NOT flag):
- Pre-existing issues
@@ -93,6 +114,8 @@ Found 3 issues:
<link to file and line with full sha1 + line range for context>
<sub>If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
---
- Or, if you found no issues:
@@ -103,6 +126,8 @@ Found 3 issues:
No issues found. Checked for bugs and CLAUDE.md compliance.
<sub>If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
---
- When linking to code, follow the following format precisely, otherwise the Markdown preview won't render correctly: https://github.com/anthropics/claude-code/blob/c21d3c10bc8e898b7ac1a2d745bdc9bc4e423afe/package.json#L10-L15

View File

@@ -44,17 +44,6 @@
}
]
}
],
"Notification": [
{
"hooks": [
{
"type": "command",
"command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/notification.py",
"timeout": 10
}
]
}
]
}
}

View File

@@ -1,143 +0,0 @@
#!/usr/bin/env python3
"""Notification hook executor for hookify plugin.
This script is called by Claude Code when notifications are sent.
It formats teammate idle notifications and other IPC messages for display.
"""
import os
import sys
import json
from datetime import datetime
# CRITICAL: Add plugin root to Python path for imports
PLUGIN_ROOT = os.environ.get('CLAUDE_PLUGIN_ROOT')
if PLUGIN_ROOT:
parent_dir = os.path.dirname(PLUGIN_ROOT)
if parent_dir not in sys.path:
sys.path.insert(0, parent_dir)
if PLUGIN_ROOT not in sys.path:
sys.path.insert(0, PLUGIN_ROOT)
def format_idle_notification(data: dict) -> str:
"""Format an idle notification for display.
Args:
data: The notification data containing type, from, timestamp, etc.
Returns:
Formatted string for display
"""
worker_name = data.get('from', 'worker')
timestamp = data.get('timestamp', '')
# Format timestamp if present
time_str = ''
if timestamp:
try:
dt = datetime.fromisoformat(timestamp.replace('Z', '+00:00'))
time_str = dt.strftime('%H:%M:%S')
except (ValueError, AttributeError):
time_str = ''
# Build the formatted output using the suggested format
lines = [f"{worker_name}"]
if time_str:
lines.append(f" ⎿ Status is idle ({time_str})")
else:
lines.append(" ⎿ Status is idle")
return '\n'.join(lines)
def format_notification(notification_content: str) -> dict:
"""Parse and format a notification message.
Args:
notification_content: Raw notification content (may be JSON or plain text)
Returns:
Dict with formatted systemMessage
"""
# Try to parse as JSON first
try:
data = json.loads(notification_content)
# Check if this is an idle notification
if isinstance(data, dict) and data.get('type') == 'idle_notification':
formatted = format_idle_notification(data)
return {"systemMessage": formatted}
# Handle other notification types
notification_type = data.get('type', '') if isinstance(data, dict) else ''
if notification_type == 'status_update':
worker = data.get('from', 'worker')
status = data.get('status', 'unknown')
return {"systemMessage": f"{worker}\n ⎿ Status: {status}"}
if notification_type == 'progress_update':
worker = data.get('from', 'worker')
progress = data.get('progress', '')
return {"systemMessage": f"{worker}\n{progress}"}
# For unknown JSON types, still try to format nicely
if isinstance(data, dict) and 'from' in data:
worker = data.get('from', 'worker')
msg = data.get('message', data.get('status', 'update'))
return {"systemMessage": f"{worker}\n{msg}"}
except (json.JSONDecodeError, TypeError):
# Not JSON, return as-is
pass
return {}
def main():
"""Main entry point for Notification hook."""
try:
# Read input from stdin
input_data = json.load(sys.stdin)
# Get notification content
notification = input_data.get('notification', '')
# Also check for raw notification data in the input
if not notification and input_data.get('type') == 'idle_notification':
# The input itself is an idle notification
formatted = format_idle_notification(input_data)
result = {"systemMessage": formatted}
elif notification:
# Format the notification content
result = format_notification(notification)
else:
# Check if the input looks like an IPC message
if input_data.get('type') in ['idle_notification', 'status_update', 'progress_update']:
if input_data.get('type') == 'idle_notification':
formatted = format_idle_notification(input_data)
result = {"systemMessage": formatted}
else:
worker = input_data.get('from', 'worker')
status = input_data.get('status', input_data.get('type', 'update'))
result = {"systemMessage": f"{worker}\n{status}"}
else:
result = {}
# Always output JSON
print(json.dumps(result), file=sys.stdout)
except Exception as e:
error_output = {
"systemMessage": f"Notification format error: {str(e)}"
}
print(json.dumps(error_output), file=sys.stdout)
finally:
# ALWAYS exit 0
sys.exit(0)
if __name__ == '__main__':
main()

View File

@@ -1,50 +0,0 @@
#!/bin/bash
# Example: Format teammate idle notification
#
# This script demonstrates how to format raw JSON idle notifications
# into user-friendly display format.
#
# Usage: echo '{"type":"idle_notification","from":"worker-1","timestamp":"..."}' | ./format-idle-notification.sh
set -euo pipefail
# Read JSON from stdin
input=$(cat)
# Parse notification type
notification_type=$(echo "$input" | jq -r '.type // empty' 2>/dev/null || echo "")
if [[ "$notification_type" == "idle_notification" ]]; then
# Extract fields
worker_name=$(echo "$input" | jq -r '.from // "worker"')
timestamp=$(echo "$input" | jq -r '.timestamp // empty')
# Format timestamp if present
time_str=""
if [[ -n "$timestamp" ]]; then
# Try to format the timestamp
time_str=$(date -d "$timestamp" '+%H:%M:%S' 2>/dev/null || echo "")
fi
# Output formatted notification using recommended format:
# ⏺ worker-1
# ⎿ Status is idle
echo "$worker_name"
if [[ -n "$time_str" ]]; then
echo " ⎿ Status is idle ($time_str)"
else
echo " ⎿ Status is idle"
fi
# Output JSON for hook system
if [[ -n "$time_str" ]]; then
jq -n --arg msg "$worker_name\n ⎿ Status is idle ($time_str)" \
'{"systemMessage": $msg}'
else
jq -n --arg msg "$worker_name\n ⎿ Status is idle" \
'{"systemMessage": $msg}'
fi
else
# Not an idle notification, pass through
echo "$input"
fi

View File

@@ -344,69 +344,3 @@ fi
- Per-project settings
- Team-specific rules
- Dynamic validation criteria
## Pattern 11: Format Teammate Idle Notifications
Format raw JSON IPC messages from workers/teammates into user-friendly display:
```json
{
"Notification": [
{
"matcher": "*",
"hooks": [
{
"type": "command",
"command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/notification.py",
"timeout": 10
}
]
}
]
}
```
**Example script (format-idle-notification.py):**
```python
#!/usr/bin/env python3
import sys
import json
def format_idle_notification(data):
"""Format idle notification for display."""
worker_name = data.get('from', 'worker')
# Output format:
# ⏺ worker-1
# ⎿ Status is idle
return f"{worker_name}\n ⎿ Status is idle"
def main():
input_data = json.load(sys.stdin)
# Check for idle notification
if input_data.get('type') == 'idle_notification':
formatted = format_idle_notification(input_data)
print(json.dumps({"systemMessage": formatted}))
else:
print(json.dumps({}))
if __name__ == '__main__':
main()
```
**Input (raw JSON IPC message):**
```json
{"type": "idle_notification", "from": "worker-1", "timestamp": "2025-12-15T05:22:40.320Z"}
```
**Output (formatted for display):**
```
⏺ worker-1
⎿ Status is idle
```
**Use for:**
- Formatting teammate/worker status messages
- Converting internal IPC messages to user-friendly display
- Multi-agent swarm coordination UI
- Any notification that shouldn't show raw JSON to users