mirror of
https://github.com/anthropics/claude-code.git
synced 2026-04-19 01:52:42 +00:00
Compare commits
1 Commits
claude/sla
...
claude/sla
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3a1c529e23 |
221
ANT_ONLY_METADATA_USER_ID_SPEC.md
Normal file
221
ANT_ONLY_METADATA_USER_ID_SPEC.md
Normal file
@@ -0,0 +1,221 @@
|
||||
# ANT_ONLY_METADATA_USER_ID Implementation Specification
|
||||
|
||||
## Overview
|
||||
|
||||
This document specifies the implementation of the `ANT_ONLY_METADATA_USER_ID` environment variable feature for Claude Code. This feature allows internal Anthropic jobs (like Claude Oracle, Oncall, Ambient, etc.) to pass custom metadata through Claude Code sessions to the Anthropic API for tracking, rate limiting, and incident triage purposes.
|
||||
|
||||
## Background
|
||||
|
||||
From the Slack discussion:
|
||||
- Internal API jobs launched via Claude Code currently lack user metadata showing `job_id` or `username` in `api_usage`
|
||||
- ~85% of requests from heavy CC users (like Closing The Loop org) have no user_metadata or job identifier
|
||||
- This metadata is critical for:
|
||||
- Managing Internal API rate limits
|
||||
- Triaging incidents
|
||||
- Setting up alerting that pings the DRI researchers
|
||||
- Understanding which jobs are driving token usage
|
||||
|
||||
## Requirements
|
||||
|
||||
1. **Environment Variable**: Claude Code must read an environment variable called `ANT_ONLY_METADATA_USER_ID`
|
||||
2. **API Integration**: The value must be passed to all Anthropic Messages API calls in the `metadata.user_id` field
|
||||
3. **Tree Shaking**: Only Anthropic internal builds should be able to use this feature
|
||||
4. **Format**: The expected format is a JSON object: `{"user": "<anthropic_username>", "job": "<job_name>"}`
|
||||
- Example: `{"user": "tedm", "job": "tedm-1208-mu-g-18x"}`
|
||||
- Or: `{"user": "vinke", "job": "claude-oracle:fluorine:vinke"}`
|
||||
|
||||
## Implementation
|
||||
|
||||
### 1. Environment Variable Reading
|
||||
|
||||
In the appropriate configuration/env module (likely `src/config/env.ts` or similar):
|
||||
|
||||
```typescript
|
||||
// Environment variable for Anthropic internal builds only
|
||||
// This is used to pass job metadata to the API for usage tracking
|
||||
export function getAntOnlyMetadataUserId(): string | undefined {
|
||||
// Only available in Anthropic internal builds
|
||||
if (!isAnthropicBuild()) {
|
||||
return undefined;
|
||||
}
|
||||
return process.env.ANT_ONLY_METADATA_USER_ID;
|
||||
}
|
||||
```
|
||||
|
||||
### 2. API Request Metadata
|
||||
|
||||
When constructing API requests to the Anthropic Messages API, add the metadata:
|
||||
|
||||
```typescript
|
||||
// In the API client module (e.g., src/api/anthropic.ts)
|
||||
import { getAntOnlyMetadataUserId } from '../config/env';
|
||||
|
||||
function buildApiRequestMetadata(): Record<string, string> | undefined {
|
||||
const metadataUserId = getAntOnlyMetadataUserId();
|
||||
|
||||
if (!metadataUserId) {
|
||||
return undefined;
|
||||
}
|
||||
|
||||
return {
|
||||
user_id: metadataUserId
|
||||
};
|
||||
}
|
||||
|
||||
// When creating a message:
|
||||
const response = await client.messages.create({
|
||||
model: selectedModel,
|
||||
max_tokens: maxTokens,
|
||||
messages: conversationMessages,
|
||||
// ... other parameters
|
||||
metadata: buildApiRequestMetadata()
|
||||
});
|
||||
```
|
||||
|
||||
### 3. Tree Shaking for Internal Builds
|
||||
|
||||
The feature should be conditionally compiled out for public builds using build-time flags:
|
||||
|
||||
```typescript
|
||||
// Using a build-time constant
|
||||
declare const __ANT_INTERNAL_BUILD__: boolean;
|
||||
|
||||
export function isAnthropicBuild(): boolean {
|
||||
// This will be replaced at build time
|
||||
// For internal builds: true
|
||||
// For public builds: false (and the code will be tree-shaken)
|
||||
if (typeof __ANT_INTERNAL_BUILD__ !== 'undefined') {
|
||||
return __ANT_INTERNAL_BUILD__;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
```
|
||||
|
||||
In the build configuration (esbuild/webpack/rollup):
|
||||
|
||||
```javascript
|
||||
// For public builds:
|
||||
define: {
|
||||
'__ANT_INTERNAL_BUILD__': 'false'
|
||||
}
|
||||
|
||||
// For internal builds:
|
||||
define: {
|
||||
'__ANT_INTERNAL_BUILD__': 'true'
|
||||
}
|
||||
```
|
||||
|
||||
### 4. Validation (Optional but Recommended)
|
||||
|
||||
```typescript
|
||||
function validateMetadataUserId(value: string): boolean {
|
||||
try {
|
||||
const parsed = JSON.parse(value);
|
||||
return typeof parsed.user === 'string' && typeof parsed.job === 'string';
|
||||
} catch {
|
||||
// Also allow simple string format for backward compatibility
|
||||
return typeof value === 'string' && value.length > 0;
|
||||
}
|
||||
}
|
||||
|
||||
export function getValidatedAntOnlyMetadataUserId(): string | undefined {
|
||||
const value = getAntOnlyMetadataUserId();
|
||||
if (value && !validateMetadataUserId(value)) {
|
||||
console.warn('ANT_ONLY_METADATA_USER_ID has invalid format. Expected JSON: {"user": "...", "job": "..."}');
|
||||
return undefined;
|
||||
}
|
||||
return value;
|
||||
}
|
||||
```
|
||||
|
||||
## Usage by Internal Services
|
||||
|
||||
Services like Claude Oracle should set this environment variable before launching Claude Code sessions:
|
||||
|
||||
```python
|
||||
# In Claude Oracle / coo job code
|
||||
import os
|
||||
import json
|
||||
|
||||
# Set the metadata before spawning Claude Code
|
||||
os.environ['ANT_ONLY_METADATA_USER_ID'] = json.dumps({
|
||||
"user": username, # Anthropic username
|
||||
"job": job_name # e.g., "claude-oracle:fluorine:vinke"
|
||||
})
|
||||
|
||||
# Then launch Claude Code session...
|
||||
```
|
||||
|
||||
Or via command line:
|
||||
|
||||
```bash
|
||||
ANT_ONLY_METADATA_USER_ID='{"user":"tedm","job":"tedm-1208-mu-g-18x"}' claude --headless ...
|
||||
```
|
||||
|
||||
## Data Flow
|
||||
|
||||
```
|
||||
┌─────────────────────────────────────────────────────────────────┐
|
||||
│ COO Job / Oracle / Oncall / etc. │
|
||||
│ Sets: ANT_ONLY_METADATA_USER_ID='{"user":"..","job":".."}' │
|
||||
└─────────────────────────────────────────────────────────────────┘
|
||||
│
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────┐
|
||||
│ Claude Code CLI │
|
||||
│ Reads: process.env.ANT_ONLY_METADATA_USER_ID │
|
||||
│ Adds to API calls: metadata: { user_id: "..." } │
|
||||
└─────────────────────────────────────────────────────────────────┘
|
||||
│
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────┐
|
||||
│ Anthropic API │
|
||||
│ Receives: metadata.user_id in request │
|
||||
│ Stores in: api_usage.metadata_user_id (BigQuery) │
|
||||
└─────────────────────────────────────────────────────────────────┘
|
||||
│
|
||||
▼
|
||||
┌─────────────────────────────────────────────────────────────────┐
|
||||
│ BigQuery: anthropic.api_production.api_usage │
|
||||
│ Fields populated: │
|
||||
│ - metadata_user_id │
|
||||
│ - device_id (if included) │
|
||||
│ - claude_code_session_id (if included) │
|
||||
└─────────────────────────────────────────────────────────────────┘
|
||||
```
|
||||
|
||||
## Testing
|
||||
|
||||
1. **Unit Tests**:
|
||||
- Test that `getAntOnlyMetadataUserId()` returns undefined when env var is not set
|
||||
- Test that it returns the value when set (in internal builds)
|
||||
- Test validation of JSON format
|
||||
|
||||
2. **Integration Tests**:
|
||||
- Verify metadata is included in API requests
|
||||
- Verify tree-shaking removes the code in public builds
|
||||
|
||||
3. **E2E Validation** (after deployment):
|
||||
- Run a Claude Code session with the env var set
|
||||
- Query BigQuery `anthropic.api_production.api_usage` to verify `metadata_user_id` is populated
|
||||
|
||||
## Security Considerations
|
||||
|
||||
1. **Internal Only**: The tree-shaking ensures this feature is not available in public builds
|
||||
2. **No Secrets**: The metadata should not contain sensitive information
|
||||
3. **Validation**: Input validation prevents injection attacks
|
||||
|
||||
## Related Files to Modify (Internal Repo)
|
||||
|
||||
Based on patterns in the bundled CLI, likely files to modify:
|
||||
|
||||
1. `src/config/env.ts` or similar - Add env var reading
|
||||
2. `src/api/anthropic.ts` or similar - Add metadata to API requests
|
||||
3. `build.config.ts` or similar - Add build-time flag for internal builds
|
||||
4. Tests for the above
|
||||
|
||||
## References
|
||||
|
||||
- Slack thread: Internal API metadata discussion
|
||||
- BigQuery tables: `anthropic.api_production.api_usage`, `api_events`
|
||||
- Anthropic API docs: [Messages API metadata parameter](https://docs.anthropic.com/en/api/messages)
|
||||
27
CHANGELOG.md
27
CHANGELOG.md
@@ -1,32 +1,5 @@
|
||||
# Changelog
|
||||
|
||||
## 2.0.69
|
||||
|
||||
- Minor bugfixes
|
||||
|
||||
## 2.0.68
|
||||
|
||||
- Fixed IME (Input Method Editor) support for languages like Chinese, Japanese, and Korean by correctly positioning the composition window at the cursor
|
||||
- Fixed a bug where disallowed MCP tools were visible to the model
|
||||
- Fixed an issue where steering messages could be lost while a subagent is working
|
||||
- Fixed Option+Arrow word navigation treating entire CJK (Chinese, Japanese, Korean) text sequences as a single word instead of navigating by word boundaries
|
||||
- Improved plan mode exit UX: show simplified yes/no dialog when exiting with empty or missing plan instead of throwing an error
|
||||
- Add support for enterprise managed settings. Contact your Anthropic account team to enable this feature.
|
||||
|
||||
## 2.0.67
|
||||
|
||||
- Thinking mode is now enabled by default for Opus 4.5
|
||||
- Thinking mode configuration has moved to /config
|
||||
- Added search functionality to `/permissions` command with `/` keyboard shortcut for filtering rules by tool name
|
||||
- Show reason why autoupdater is disabled in `/doctor`
|
||||
- Fixed false "Another process is currently updating Claude" error when running `claude update` while another instance is already on the latest version
|
||||
- Fixed MCP servers from `.mcp.json` being stuck in pending state when running in non-interactive mode (`-p` flag or piped input)
|
||||
- Fixed scroll position resetting after deleting a permission rule in `/permissions`
|
||||
- Fixed word deletion (opt+delete) and word navigation (opt+arrow) not working correctly with non-Latin text such as Cyrillic, Greek, Arabic, Hebrew, Thai, and Chinese
|
||||
- Fixed `claude install --force` not bypassing stale lock files
|
||||
- Fixed consecutive @~/ file references in CLAUDE.md being incorrectly parsed due to markdown strikethrough interference
|
||||
- Windows: Fixed plugin MCP servers failing due to colons in log directory paths
|
||||
|
||||
## 2.0.65
|
||||
|
||||
- Added ability to switch models while writing a prompt using alt+p (linux, windows), option+p (macos).
|
||||
|
||||
@@ -26,24 +26,19 @@ Performs automated code review on a pull request using multiple specialized agen
|
||||
|
||||
**Usage:**
|
||||
```bash
|
||||
/code-review [--comment]
|
||||
/code-review
|
||||
```
|
||||
|
||||
**Options:**
|
||||
- `--comment`: Post the review as a PR comment on GitHub. By default, the review is output to the terminal only.
|
||||
|
||||
**Example workflow:**
|
||||
```bash
|
||||
# On a PR branch, run (outputs to terminal only):
|
||||
# On a PR branch, run:
|
||||
/code-review
|
||||
|
||||
# Claude will:
|
||||
# - Launch 4 review agents in parallel
|
||||
# - Score each issue for confidence
|
||||
# - Output review with issues ≥80 confidence to terminal
|
||||
|
||||
# To post review as a GitHub PR comment:
|
||||
/code-review --comment
|
||||
# - Post comment with issues ≥80 confidence
|
||||
# - Skip posting if no high-confidence issues found
|
||||
```
|
||||
|
||||
**Features:**
|
||||
@@ -54,7 +49,6 @@ Performs automated code review on a pull request using multiple specialized agen
|
||||
- Historical context analysis via git blame
|
||||
- Automatic skipping of closed, draft, or already-reviewed PRs
|
||||
- Links directly to code with full SHA and line ranges
|
||||
- Local-only output by default; use `--comment` flag to post to GitHub PR
|
||||
|
||||
**Review comment format:**
|
||||
```markdown
|
||||
@@ -202,7 +196,6 @@ https://github.com/owner/repo/blob/[full-sha]/path/file.ext#L[start]-L[end]
|
||||
- **Iterate on guidelines**: Update CLAUDE.md based on patterns
|
||||
- **Review automatically**: Set up as part of PR workflow
|
||||
- **Trust the filtering**: Threshold prevents noise
|
||||
- **Use `--comment` for CI/CD**: Post review to PR when running in automated workflows
|
||||
|
||||
## Configuration
|
||||
|
||||
|
||||
@@ -5,9 +5,6 @@ description: Code review a pull request
|
||||
|
||||
Provide a code review for the given pull request.
|
||||
|
||||
**Arguments:**
|
||||
- `--comment`: Post the review as a PR comment on GitHub. By default, the review is output to the terminal only.
|
||||
|
||||
To do this, follow these steps precisely:
|
||||
|
||||
1. Launch a haiku agent to check if any of the following are true:
|
||||
@@ -55,11 +52,8 @@ Note: Still review Claude generated PR's.
|
||||
|
||||
6. Filter out any issues that were not validated in step 5. This step will give us our list of high signal issues for our review.
|
||||
|
||||
7. Finally, output the review:
|
||||
- If `--comment` was passed as an argument, post the review as a comment on the pull request using `gh pr comment`
|
||||
- Otherwise, output the review directly to the terminal (do NOT post to GitHub)
|
||||
|
||||
When writing your review, follow these guidelines:
|
||||
7. Finally, comment on the pull request.
|
||||
When writing your comment, follow these guidelines:
|
||||
a. Keep your output brief
|
||||
b. Avoid emojis
|
||||
c. Link and cite relevant code, files, and URLs for each issue
|
||||
@@ -99,6 +93,11 @@ Found 3 issues:
|
||||
|
||||
<link to file and line with full sha1 + line range for context>
|
||||
|
||||
🤖 Generated with [Claude Code](https://claude.ai/code)
|
||||
|
||||
|
||||
<sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
|
||||
|
||||
---
|
||||
|
||||
- Or, if you found no issues:
|
||||
@@ -109,6 +108,8 @@ Found 3 issues:
|
||||
|
||||
No issues found. Checked for bugs and CLAUDE.md compliance.
|
||||
|
||||
🤖 Generated with [Claude Code](https://claude.ai/code)
|
||||
|
||||
---
|
||||
|
||||
- When linking to code, follow the following format precisely, otherwise the Markdown preview won't render correctly: https://github.com/anthropics/claude-code/blob/c21d3c10bc8e898b7ac1a2d745bdc9bc4e423afe/package.json#L10-L15
|
||||
|
||||
Reference in New Issue
Block a user