mirror of
https://github.com/anthropics/claude-plugins-official.git
synced 2026-06-10 10:13:36 +00:00
Fixes anthropics/claude-plugins-official#2071 — on macOS where the default `python3` is Apple's Command Line Tools Python 3.9.6, the plugin's agentic commit reviewer silently does not run, even when the user has a newer Python installed. Three compounding factors in the bug: 1. `sg-python.sh` only checks the major version (`3`), so it always picks 3.9 even when 3.10+ is on PATH. 2. `claude_agent_sdk` requires Python >=3.10 — pip install on 3.9 returns "No matching distribution" -> bootstrap returns BUILD_FAILED. 3. Even with a hand-built 3.12 venv, `llm.py` imports the SDK in-process into the hook's interpreter (still 3.9), which raises SyntaxError. The existing venv-probe in `ensure_agent_sdk.py` uses the venv's own Python (3.12) so it reports NOOP_VENV (healthy) while the consumer fails — misleading telemetry on top of silent feature degradation. Per BQ telemetry, 14,073 external macOS users hit sdk_bootstrap=BUILD_FAILED in the past 4 days (the default-macOS cohort), out of ~86K total external installed users. Combined with ~20K other users in similar broken-bootstrap states (Windows pre-#2055, Linux <3.10), about half the installed base has a silently-broken agentic reviewer. This PR implements the reporter's items #1, #3, and #4. Item #2 (running the SDK out-of-process) is deferred as a bigger refactor. Item #1 — hooks/sg-python.sh — prefer >=3.10 binaries via 3-pass probe: Pass 1: python3.13 / 3.12 / 3.11 / 3.10 (>=3.10 by name, highest wins) Pass 2: bare python3 / python / py -3 (accept only if reported >=3.10) Pass 3: bare python3 / python / py -3 (any Python 3, FALLBACK so pattern checks still work on macOS-default 3.9 — no regression vs today; SDK-dependent paths detect the version mismatch inside Python and degrade cleanly via item #4) Item #4 — ensure_agent_sdk.py — health-check honesty: Added HOOK_PY_INCOMPATIBLE=6 outcome with short-circuit at top of main(): if sys.version_info < (3, 10): return HOOK_PY_INCOMPATIBLE, "hook_py", f"py_{...}" Telemetry consequences after rollout: sdk_bootstrap=6 is a new clean bucket; some users currently miscounted in sdk_bootstrap=3 BUILD_FAILED (wasted pip cycles) and sdk_bootstrap=1 NOOP_VENV (falsely-healthy) move to sdk_bootstrap=6. The remaining NOOP_VENV count becomes trustworthy. Item #3 — ensure_agent_sdk.py — one-time user-visible notice: When outcome == HOOK_PY_INCOMPATIBLE and a marker file at `~/.claude/security/.agentic_unavailable_notice_v<pv>` doesn't exist, the SessionStart response includes hookSpecificOutput.additionalContext + systemMessage explaining the situation. Marker file is plugin- version-keyed so a future fix (e.g. shipping out-of-process SDK) can bump pv and re-notify users. BUILD_FAILED is intentionally excluded from the notice — it covers transient causes where a permanent banner would mislead. Verified locally on macOS Python 3.13: - py_compile clean on both files. - Existing 45-test smoke + extensibility suite: 45/45 PASS in 2.50s. - Unit test of simulated 3.9 path: HOOK_PY_INCOMPATIBLE returned with correct phase/kind; notice shown on first call, suppressed on second, reshown on bumped pv; BUILD_FAILED correctly does NOT trigger notice. NOT verified: actual Python 3.9 behavior end-to-end (would need a 3.9 install). Worth a follow-up smoke test in a 3.9 venv before next release. The unit test simulating 3.9 covers the logic but not the runtime invocation through the shim. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
112 lines
4.8 KiB
Bash
Executable File
112 lines
4.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Find a working Python 3 interpreter and exec the hook with it.
|
|
#
|
|
# On Windows + Git Bash, `python3` typically resolves to the Microsoft Store
|
|
# stub at C:\Users\<user>\AppData\Local\Microsoft\WindowsApps\python3, which
|
|
# exits 49 silently in non-TTY subprocess context (a known Microsoft Store
|
|
# stub behavior). This shim
|
|
# probes each candidate with `-c ""` and skips any that fails, so the Store
|
|
# stub falls through to the real python.org install (`python` in Git Bash) or
|
|
# the `py -3` launcher.
|
|
#
|
|
# Order:
|
|
# 1. python3 — canonical on macOS/Linux; the Store stub fails the probe.
|
|
# 2. python — python.org installs on Windows; some Linux distros (RHEL 7
|
|
# EOL'd 2024-06) point this at Python 2, but `-c ""` succeeds
|
|
# on Python 2 too — guard with a version check.
|
|
# 3. py -3 — Windows Python launcher.
|
|
#
|
|
# Args after the shim path are passed straight through to the chosen
|
|
# interpreter, so the hooks.json invocation is:
|
|
# bash "${CLAUDE_PLUGIN_ROOT}/hooks/sg-python.sh" \
|
|
# "${CLAUDE_PLUGIN_ROOT}/hooks/security_reminder_hook.py"
|
|
set -e
|
|
|
|
# Git Bash / MSYS on Windows hands script paths to this shim in POSIX form
|
|
# (`/c/Users/...`). When we exec a Windows `python.exe` (which we do on
|
|
# Windows since `python3` is the Microsoft Store stub), python interprets the
|
|
# leading `/` as the root of the current drive — e.g. `/c/Users/...` becomes
|
|
# `C:\c\Users\...` or `D:\c\Users\...` (whichever drive the shell is on),
|
|
# fails with ENOENT, and every Edit/Write/MultiEdit tool use blocks until the
|
|
# session restarts. See anthropics/claude-plugins-official#2043.
|
|
#
|
|
# Fix: convert absolute path args to native Windows form via `cygpath -w`
|
|
# before exec. `cygpath` is a Git Bash builtin; it's absent on macOS/Linux,
|
|
# where the `command -v` guard makes this a no-op. `cygpath -w` is idempotent
|
|
# for already-Windows paths so the rare mixed-form case is safe.
|
|
if command -v cygpath >/dev/null 2>&1; then
|
|
converted=()
|
|
for a in "$@"; do
|
|
case "$a" in
|
|
/*) converted+=("$(cygpath -w "$a")") ;;
|
|
*) converted+=("$a") ;;
|
|
esac
|
|
done
|
|
set -- "${converted[@]}"
|
|
fi
|
|
|
|
probe() {
|
|
# $1..N: the interpreter command (may be multi-word like `py -3`)
|
|
# Writes "<major>.<minor>" to stdout and exits 0 iff at least Python 3.
|
|
"$@" -c 'import sys; print(f"{sys.version_info[0]}.{sys.version_info[1]}")' 2>/dev/null
|
|
}
|
|
|
|
# True iff arg is a "M.m" version string >= 3.10. claude_agent_sdk requires
|
|
# Python >= 3.10; below that, pip install fails ("No matching distribution")
|
|
# and the LLM-powered review (Stop / commit / push) silently no-ops while
|
|
# pattern checks (PostToolUse regex) keep working. macOS ships 3.9.6 as the
|
|
# default `python3` on current versions, so this guard matters in practice.
|
|
# See anthropics/claude-plugins-official#2071.
|
|
is_sdk_compatible() {
|
|
case "$1" in
|
|
3.1[0-9]|3.[2-9][0-9]|[4-9].*|[1-9][0-9].*) return 0 ;;
|
|
*) return 1 ;;
|
|
esac
|
|
}
|
|
|
|
# Pass 1 — try minor-versioned binaries in descending order. These are only
|
|
# present if the user explicitly installed them (Homebrew / python.org / pyenv),
|
|
# so picking one here always upgrades over the system `python3`. Highest
|
|
# available wins; the user doesn't have to PATH-prefer it.
|
|
for cmd in "python3.13" "python3.12" "python3.11" "python3.10"; do
|
|
v=$(probe "$cmd") || continue
|
|
if is_sdk_compatible "$v"; then
|
|
exec "$cmd" "$@"
|
|
fi
|
|
done
|
|
|
|
# Pass 2 — bare interpreters, but only if SDK-compatible. Covers Linux distros
|
|
# that ship 3.10+ as the default `python3`, and Windows where `python` /
|
|
# `py -3` resolves to the user's python.org install.
|
|
for cmd in "python3" "python" "py -3"; do
|
|
# shellcheck disable=SC2086
|
|
v=$(probe $cmd) || continue
|
|
if is_sdk_compatible "$v"; then
|
|
# shellcheck disable=SC2086
|
|
exec $cmd "$@"
|
|
fi
|
|
done
|
|
|
|
# Pass 3 — fallback to any Python 3, even <3.10. Pattern-based checks
|
|
# (PostToolUse regex on Edit/Write) only need 3.6+ and are useful on their
|
|
# own; the SDK-dependent paths will detect the version mismatch and degrade
|
|
# inside the Python code. Without this fallback, the entire plugin would
|
|
# stop working on default macOS, which is a regression vs today.
|
|
for cmd in "python3" "python" "py -3"; do
|
|
# shellcheck disable=SC2086
|
|
v=$(probe $cmd) || continue
|
|
# Accept anything that successfully reported a "M.m" string.
|
|
case "$v" in
|
|
[0-9]*.[0-9]*)
|
|
# shellcheck disable=SC2086
|
|
exec $cmd "$@"
|
|
;;
|
|
esac
|
|
done
|
|
|
|
echo "security-guidance: no working Python 3 interpreter found." >&2
|
|
echo " tried: python3.13, python3.12, python3.11, python3.10, python3, python, py -3" >&2
|
|
echo " on Windows, install Python from https://python.org (NOT the Microsoft Store)" >&2
|
|
echo " on macOS, install Python 3.10+ via Homebrew (\`brew install python\`)" >&2
|
|
exit 1
|